feat(storage): Create OTel tracing decorator for client:: WriteObject()#15290
feat(storage): Create OTel tracing decorator for client:: WriteObject()#15290shubham-up-47 wants to merge 9 commits intogoogleapis:mainfrom
client:: WriteObject()#15290Conversation
product-auto-label
bot
added
the
api: storage
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15290 +/- ##
==========================================
- Coverage 92.98% 92.97% -0.01%
==========================================
Files 2402 2402
Lines 217996 218045 +49
==========================================
+ Hits 202694 202721 +27
- Misses 15302 15324 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @ddelgrosso1, I raised this PR for the feature request #11394. In this, I am logging a new trace Does this trace look okay for that feature request? |
Including @bajajneha27 too. WDYT? |
Looks like you're only moving the implementation of |
Yes, It is intentional so that we can have a unique trace which is emitted by the The traces (like To have that, i was proposing the trace WriteObjectBufferSize here. If this doesn't look good, we can have another method something like SetupObjectWriteStream or InitializeObjectWriteStreamParams to initialize all the params of the next function call (i.e. ObjectWriteStream), currently i was initializing only one param of the next method call. |
Created a struct ObjectWriteStreamParams and using method SetupObjectWriteStream to initialize all the params of the next function which emits the |
|
@shubham-up-47 As discussed offline, I think the task is to add a span for the |
3 participants
Moving some implementation logic of the method WriteObjectImpl from client.cc file to connection_impl.cc file, so that complate tracing of client:: WriteObject can be enabled (#11394).
Trace screenshot: https://screenshot.googleplex.com/3FS8Z5pR67ZNx3i
This change is